[RFC/PATCH] Add test case for loop.c

[Dmitry V. Levin]

On Thu, Mar 26, 2020 at 12:37:00PM +0530, Dhanuka Warusadura wrote:
> This patch adds a test case for loop.c. Currently loop.c has 97.6%
> covered and this patch intend complete the rest.

According to https://codecov.io/gh/strace/strace/branch/master
loop.c has 100% coverage.

> Signed-off-by: Dhanuka Warusadura <csx at disroot.org>
> ---
>  loop.c             | 3 ++-
>  tests/ioctl_loop.c | 3 ++-
>  2 files changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/loop.c b/loop.c
> index 36a40c55..0afda70f 100644
> --- a/loop.c
> +++ b/loop.c
> @@ -69,7 +69,8 @@ decode_loop_info(struct tcb *const tcp, const kernel_ulong_t addr)
>  	}
>  
>  	if (!abbrev(tcp))
> -		tprintf(", lo_init=[%#" PRI_klx ", %#" PRI_klx "]"
> +		tprintf(", lo_init=[%#" PRI_klx ", %#" PRI_klx ", \
> +                %#" PRI_klx ", %#" PRI_klx "]"
>  			", reserved=[%#hhx, %#hhx, %#hhx, %#hhx]}",
>  			(kernel_ulong_t) info.lo_init[0],
>  			(kernel_ulong_t) info.lo_init[1],

What do you mean by suggesting this change?  Does it compile?


-- 
ldv