[PATCH v2 2/2] ioctl console test v2

Bran S archsbran at gmail.com
Mon Mar 9 13:11:53 UTC 2020


> > -// #include "tests.h"
>
> All tests should include this header file unless they have a strong reason
> not to include it.

I removed it because it wasn't being used. Should I add it ?

> This change probably fixes those two warnings reported by the compiler,
> but the test still fails.  I'm not sure that's the purpose of submitting
> a test that's expected to fail.

PASS: ioctl_block.gen.test
PASS: ioctl_console.gen.test
PASS: ioctl_dm.gen.test

FAIL: strace-DDD
================

1351 1127 26203
strace-DDD.test: failed test: ../../strace -D -enone -esignal=none
../tracer_ppid_pgid_sid: unexpected output
FAIL strace-DDD.test (exit status: 1)

The test report from my system. Only one test i.e. strace-DDD.test
fails. This test has been known to fail. ioctl_console.gen.test
passes.

> By the way, have you seen a "work in progress" branch esyr/kd?

I see it. Do I need to make changes in the test w.r.t. esyr/kd ?


More information about the Strace-devel mailing list