[RFC PATCH v2 11/12] Use printpid in decoders

Dmitry V. Levin ldv at altlinux.org
Fri Jun 12 19:38:40 UTC 2020


On Fri, Jun 12, 2020 at 08:24:05PM +0200, Ákos Uzonyi wrote:
[...]
> --- a/printsiginfo.c
> +++ b/printsiginfo.c
> @@ -58,6 +58,11 @@
>  static void
>  printsigsource(const siginfo_t *sip)
>  {
> +	/*
> +	TODO
> +	We don't have a tcb here to translate this PID
> +	Should I add a tcb parameter to every function in the call hiearchy?
> +	*/

Yes, feel free to add a tcb parameter.

[...]
> --- a/sockaddr.c
> +++ b/sockaddr.c
> @@ -411,6 +411,11 @@ print_sockaddr_data_nl(const void *const buf, const int addrlen)
>  {
>  	const struct sockaddr_nl *const sa_nl = buf;
>  
> +	/*
> +	TODO
> +	We don't have a tcb here to translate this PID
> +	Should I add a tcb parameter to sockaddr_printer?
> +	*/

Yes, feel free to add a tcb parameter.


-- 
ldv


More information about the Strace-devel mailing list