[PATCH v2 3/7] Use printpid in decoders

Ákos Uzonyi uzonyi.akos at gmail.com
Thu Jul 23 11:38:07 UTC 2020


On Thu, 23 Jul 2020 at 00:47, Dmitry V. Levin <ldv at altlinux.org> wrote:
> On Tue, Jul 21, 2020 at 11:19:21PM +0200, Ákos Uzonyi wrote:
> [...]
> > * tests/bpf.c (BPF_TASK_FD_QUERY_checks): Use smaller PIDs.
> > * tests/ioctl_block.c (main): Print PID as signed integer.
>
> I couldn't find these changes in the patch. :)

Oh, you made these exact changes in 2ce9e7ec, so rebasing on master
removed them from this patch :).

> [...]
> > --- a/tests/pidfd_send_signal.c
> > +++ b/tests/pidfd_send_signal.c
> > @@ -57,7 +57,7 @@ main(void)
> >              ", si_code=SI_QUEUE, si_errno=%u, si_pid=%d, si_uid=%d"
> >              ", si_value={int=%d, ptr=%p}}, %#x) = %s\n",
> >              fd, si->si_errno, si->si_pid, si->si_uid, si->si_int, si->si_ptr,
> > -            -1U, errstr);
> > +            -1, errstr);
>
> As the value is printed using %#x format, why this change is needed?

Right, this change is not needed.


More information about the Strace-devel mailing list