[PATCH v2 0/7] [PIDNS] Final

[Dmitry V. Levin]

On Tue, Jul 21, 2020 at 11:19:18PM +0200, Ákos Uzonyi wrote:
> From: Uzonyi Ákos <uzonyi.akos at gmail.com>
> 
> I made the requested changes to my prevoius series.
> 
> I ran a travis build [1], it seems to be fine, but on x86 all the pidns tests
> are failing. According to the error message, ioctl(NS_GET_PARENT) errors
> with ENOTTY. I have no idea why it happens, on my x86 system all tests pass.
> If you know the reason of it, please tell me.
> 
> [1] https://travis-ci.org/github/AkosUzonyi/strace/builds/710483396

Although this looks odd, it must be something to do with the kernel.
Old kernels do not have to support NS_GET_PARENT at all.
When this is the case, there is no need to complain every time
NS_GET_PARENT is invoked.  I'd suggest to skip further NS_GET_PARENT
invocations if the first one failed with ENOTTY.
Anyway, I don't think strace is allowed to segfault when NS_GET_PARENT
is not available.

I've got another issue on x86 in my system when trying to build a package:
verify-elf: ERROR: ./usr/bin/strace: uses non-LFS functions: __fxstat fopen open readdir

Looks like some new pidns.c code introduced in this series does not use
largefile_wrappers.h macros.


-- 
ldv