[PATCH] filter_seccomp: fix no-MMU build

Dmitry V. Levin ldv at altlinux.org
Wed Jan 15 19:49:19 UTC 2020


On Mon, Jan 13, 2020 at 02:59:39PM +0200, Baruch Siach wrote:
> Move the declaration of filter_generators out of HAVE_FORK ifdef to fix
> build for no-MMU targets:
> 
> filter_seccomp.c: In function ‘check_seccomp_filter_properties’:
> filter_seccomp.c:608:42: error: ‘filter_generators’ undeclared (first use in this function); did you mean ‘linear_filter_generator’?
>   for (unsigned int i = 0; i < ARRAY_SIZE(filter_generators); ++i) {
>                                           ^~~~~~~~~~~~~~~~~
> ---
>  filter_seccomp.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/filter_seccomp.c b/filter_seccomp.c
> index 91f6bc42bce3..da1abc713dfc 100644
> --- a/filter_seccomp.c
> +++ b/filter_seccomp.c
> @@ -68,8 +68,6 @@ static const struct audit_arch_t audit_arch_vec[SUPPORTED_PERSONALITIES] = {
>  # endif
>  };
>  
> -# ifdef HAVE_FORK
> -
>  typedef unsigned short (*filter_generator_t)(struct sock_filter *,
>  					     bool *overflow);
>  static unsigned short linear_filter_generator(struct sock_filter *,
> @@ -92,6 +90,8 @@ static struct sock_fprog bpf_prog = {
>  	.filter = NULL,
>  };
>  
> +# ifdef HAVE_FORK
> +
>  static void ATTRIBUTE_NORETURN
>  check_seccomp_order_do_child(void)
>  {

Applied, thanks!


-- 
ldv


More information about the Strace-devel mailing list