[PATCH v11 5/5] Add tests for PID namespace translation

[Ákos Uzonyi]

On Mon, 24 Aug 2020 at 00:36, Dmitry V. Levin <ldv at altlinux.org> wrote:
> On Mon, Aug 24, 2020 at 12:25:55AM +0200, Ákos Uzonyi wrote:
> [...]
> > --- a/tests/Makefile.am
> > +++ b/tests/Makefile.am
> > @@ -66,6 +66,8 @@ libtests_a_SOURCES = \
> >       test_ucopy.h \
> >       tests.h \
> >       tprintf.c \
> > +     trie_for_tests.c \
> > +     xmalloc_for_tests.c \
> >       # end of libtests_a_SOURCES
> >  libtests_a_CPPFLAGS = $(AM_CPPFLAGS) -D_FILE_OFFSET_BITS=64
> >  check_LIBRARIES = libtests.a
>
> Why are you adding trie_for_tests.c to libtests_a_SOURCES?
> If I understand correctly, ...
>
> > +trie_test_SOURCES = trie_test.c trie_for_tests.c
> > +trie_test_CPPFLAGS = $(AM_CPPFLAGS) $(CODE_COVERAGE_CPPFLAGS)
> > +trie_test_CFLAGS = $(AM_CFLAGS) $(CODE_COVERAGE_CFLAGS)
> > +trie_test_LDADD = $(LDADD) $(CODE_COVERAGE_LIBS)
>
> ... trie_for_tests.c is needed only in trie_test_SOURCES.

Yes, it shouldn't be added to libtests_a_SOURCES, I overlooked this
fact during conflict resolution.