[RFC PATCH 0/4] [PIDNS] Trie and pidns-cache tests

Ákos Uzonyi uzonyi.akos at gmail.com
Mon Aug 17 22:12:17 UTC 2020

On Sat, 15 Aug 2020 at 18:27, Dmitry V. Levin <ldv at altlinux.org> wrote:
> On Sat, Aug 15, 2020 at 06:23:26PM +0200, Ákos Uzonyi wrote:
> > On Sat, 15 Aug 2020 at 14:41, Dmitry V. Levin <ldv at altlinux.org> wrote:
> > > On Thu, Aug 13, 2020 at 05:32:38PM +0200, Ákos Uzonyi wrote:
> > > > is it's OK to add ../trie.c ../trie.h to libtests_a_SOURCES?
> > >
> > > I suppose automake should be fine with it.  What's your concern?
> >
> > Technically there is no problem, I just worried about including a file
> > not in tests directory, as it hasn't been done before. But if you say
> > it's OK, then everything is fine :).
> The only problem is that it won't be built with coverage support,
> so it won't be shown in coverage reports.

I found an another problem, github CI errors with:

/usr/bin/ld: i386:x86-64 architecture of input file
`libtests.a(libtests_a-trie.o)' is incompatible with i386 output

I think we could add a symlink in tests/ directory pointing to trie.c,
and use that. It would solve both problems if I'm not mistaken.

More information about the Strace-devel mailing list