[PATCH] tests: fix format warning in macros

Paul Chaignon paul.chaignon at gmail.com
Sun Sep 22 08:40:53 UTC 2019


On Sun, Sep 22, 2019 at 12:30:38AM +0300, Dmitry V. Levin wrote:
> On Sat, Sep 21, 2019 at 10:14:54PM +0200, Paul Chaignon wrote:
> > On Sat, Sep 21, 2019 at 07:13:26PM +0300, Dmitry V. Levin wrote:
> > > On Sat, Sep 21, 2019 at 03:00:51PM +0200, Paul Chaignon wrote:
> > > > tests/prctl-seccomp-filter-v.c (PRINT_ALLOW_SYSCALL, PRINT_DENY_SYSCALL):
> > > > Fix format warning.
> > > > tests/seccomp-filter-v.c (PRINT_ALLOW_SYSCALL, PRINT_DENY_SYSCALL):
> > > > Likewise.
> > > > 
> > > > Signed-off-by: Paul Chaignon <paul.chaignon at gmail.com>
> > > > ---
> > > > Two of the Travis CI builds are failing on the master branch because of
> > > > this warning.
> > > > 
> > > >  tests/prctl-seccomp-filter-v.c |  8 ++++----
> > > >  tests/seccomp-filter-v.c       | 12 ++++++------
> > > >  2 files changed, 10 insertions(+), 10 deletions(-)
> > 
> > [...]
> > 
> > > The patch looks fine, but I wonder where do these warnings come from?
> > > Has the type of __NR_* macros changed suddenly from int to long?
> > > Given that the warning arises on x32 only,
> > > is it related to the type of __X32_SYSCALL_BIT?
> > 
> > I looked for anything related in the kernel logs, but haven't been able to
> > figure out what happened.
> > 
> > Are you sure this is related to x32 though?  The two Travis CI builds that
> > failed because of this were the two builds using the latest kernel headers
> > and they also happen to be x86-64 builds.
> 
> Yes, I think this is x32 only, in all cases where the warning was issued
> the compiler was invoked with -mx32 option.

Ok, found it.  It's related to kernel commit 45e29d1 ("x86/syscalls: Make
__X32_SYSCALL_BIT be unsigned long"), which as you guessed, changed the
type of __X32_SYSCALL_BIT.  Thanks!

Paul


More information about the Strace-devel mailing list