[PATCH v1] Remove configure checks for few sys/ headers

Dmitry V. Levin ldv at altlinux.org
Tue Nov 19 10:25:17 UTC 2019


On Tue, Nov 12, 2019 at 12:42:20PM -0800, Khem Raj wrote:
> sys/ipc.h, sys/sem.h, sys/shm.h, and sys/msg.h are actually wrappers
> for kernel headers in libc if available, here strace is trying to match
> traced process's APIs to syscalls kernel structures
> 
> Removing the checks makes it default to right kernel UAPI headers
> under linux/

Thanks, I've given this patch a wider testing, and the news are not good.

According to strace testsuite, this change, unfortunately, causes
regressions: the structures returned by msgctl and shmctl syscalls
are no longer printed correctly for some architectures.  For example,
this happens with x32 tracee on x86_64 and with 32-bit tracee on sparc64.

Apparently, kernel UAPI headers are not good enough for this job,
compared with glibc headers.


-- 
ldv
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.strace.io/pipermail/strace-devel/attachments/20191119/dac0b0c6/attachment.bin>


More information about the Strace-devel mailing list