[PATCH v2] s390: fix SIGNAL_FRAMESIZE macro

Dmitry V. Levin ldv at altlinux.org
Mon Mar 18 12:58:52 UTC 2019


On Mon, Mar 18, 2019 at 01:40:56PM +0100, Tuan Hoang wrote:
> On 3/18/19 1:05 PM, Dmitry V. Levin wrote:
> > 
> > I've been told off-list about a typo in the sentence above.
> > What I meant to say is that
> > it defined SIGNAL_FRAMESIZE to 96 instead of 160 on s390x.
> > 
> I also assume that.
> 
> >> If you run "make check", you'd see "FAIL: rt_sigreturn.gen" on s390x.
> >>
> >> I've changed this to
> >>
> >> +#ifdef __s390x__
> >> +# define SIGNAL_FRAMESIZE 160
> >> +#else /* __s390__ */
> >> +# define SIGNAL_FRAMESIZE 96
> >> +#endif
> >>
> >> and pushed to master.
> > 
> I don't see much of a difference here but your change fixes the test
> fail above. Thanks!

On s390x both __s390__ and __s390x__ are defined, so the order of checking
these macros makes the difference.


-- 
ldv
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.strace.io/pipermail/strace-devel/attachments/20190318/2f59bd32/attachment.bin>


More information about the Strace-devel mailing list