[RFC PATCH v3 2/3] drm: implement decoding of DRM ioctls

[Patrik Jakobsson]

On Mon, Jul 29, 2019 at 03:57:51AM +0200, Eugene Syromiatnikov wrote:
> This is just a cursory review, since I haven't looked at in-kernel
> DRM ioctl implementation yet.
> 
> On Sat, Jul 27, 2019 at 11:57:16PM +0800, Zhibin Li wrote:
> 
> > (drm_version, drm_unique, drm_get_map, drm_get_client, drm_get_stats,
> > drm_add_map, drm_add_bufs, drm_mark_bufs, drm_info_bufs, drm_map_bufs,
> > drm_free_bufs, drm_rm_map, drm_sarea_ctx, drm_res_ctx, drm_agp_enable,
> > drm_agp_info, drm_agp_alloc, drm_agp_free, drm_mode_get_connector,
> > drm_scatter_gather, drm_wait_vblank, drm_mode_getplaneresources,
> > drm_mode_add_fb2, drm_mode_obj_getproperties, drm_mode_obj_setproperty
> > drm_agp_bind): New functions.
> > (drm_ioctl_mpers): Use them.
> 
> I don't thing the list of functions is required for a new file GNU-style
> changelog entry.
> 
> > (print_drm_iowr, drm_decode_number, drm_get_magic, drm_irq_busid,
> > drm_set_version, drm_modeset_ctl, drm_gem_close, drm_gem_flink,
> > drm_gem_open, drm_get_cap, drm_set_client_cap, drm_auth_magic,
> > drm_noop, drm_control, drm_ctx, drm_rm_ctx, drm_get_ctx, drm_lock,
> > drm_prime_handle_to_fd, drm_prime_fd_to_handle, drm_crtc_get_sequence,
> > drm_crtc_queue_sequence, drm_mode_get_resources, drm_mode_crtc,
> > drm_mode_print_modeinfo, drm_mode_cursor, drm_mode_get_encoder,
> > drm_mode_gamma, drm_mode_get_property, drm_mode_set_property,
> > drm_mode_get_prop_blob, drm_mode_get_fb, drm_mode_add_fb,
> > drm_mode_rm_fb, drm_mode_page_flip, drm_mode_create_dumb,
> > drm_mode_dirty_fb, drm_mode_map_dumb, drm_mode_destroy_dumb,
> > drm_mode_getplane, drm_mode_setplane, drm_mode_cursor2,
> > drm_mode_atomic, drm_mode_createpropblob, drm_mode_destroypropblob,
> > drm_syncobj_create, drm_syncobj_destroy, drm_syncobj_handle_fd,
> > drm_syncobj_wait, drm_syncobj_reset_or_signal, drm_mode_create_lease,
> > drm_mode_list_lessees, drm_mode_get_lease, drm_mode_revoke_lease,
> > drm_syncobj_timeline_wait, drm_syncobj_query_or_timeline_signal,
> > drm_syncobj_transfer): New functions.
> > (drm_ioctl): Use them and use drm_ioctl_mpers.
> 
> Ditto.
> 
> > --- /dev/null
> > +++ b/drm.c
> > @@ -0,0 +1,1531 @@
> > +/*
> > + * Copyright (c) 2019 Patrik Jakobsson <pjakobsson at suse.de>
> The copyright of the original patch dates back to (at least) 2015[1],
> and it was claimed by Intel back then.

This is my fault, forgot to add it in the rework I did. Please add back the
original copyright but also keep the current one.

-Patrik

> 
> Your copyright attribution is also missing (adding generic "The strace
> developers" attribution would be sufficient as well).
> 
> [1] https://lists.freedesktop.org/archives/intel-gfx/2015-August/074252.html
>