[PATCH v7 3/4] Implement -e status=set option

[Dmitry V. Levin]

On Sun, Jul 07, 2019 at 08:09:04PM +0300, Dmitry V. Levin wrote:
> On Sun, Jul 07, 2019 at 05:14:35PM +0200, Paul Chaignon wrote:
> > On Sun, Jul 07, 2019 at 01:08:06AM +0300, Dmitry V. Levin wrote:
> > > On Sat, Jul 06, 2019 at 09:19:57AM +0200, Paul Chaignon wrote:
> > > [...]
> > > > +.BR select (2)
> > > > +is called, but a different thread calls
> > > > +.BR clock_gettime (2)
> > > > +before
> > > > +.BR select (2)
> > > > +finishes:
> > > > +.CW
> > > > +[pid 28779] clock_gettime(CLOCK_REALTIME, {1130322148, 939977000}) = 0
> > > > +[pid 28772] select(4, [3], NULL, NULL, NULL <unfinished ...>
> > > > +[pid 28772] <... select resumed> )      = 1 (in [3])
> > > 
> > > I think in case of staging output this unfinished/resumed diagnostics
> > > is redundant and could be easily avoided, e.g.
> > 
> > I was worried the users would not notice the change of syscall's order,
> > but that not a good way to indicate it anyway.  I applied the changes and
> > fixed the tests accordingly.  Thanks!
> 
> If they want to see the order along with status filtering,
> they could use e.g. -ttt option.

I suggest to include some -ttt output to that example, e.g.

[pid 28779] 1130322148.939977 clock_gettime(CLOCK_REALTIME, {1130322148, 939977000}) = 0
[pid 28772] 1130322148.438139 select(4, [3], NULL, NULL, NULL) = 1 (in [3])

This would make the change of order more clear.


-- 
ldv
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.strace.io/pipermail/strace-devel/attachments/20190711/a4b5573b/attachment.bin>