[PATCH] Beautify s390x sthyi data tail prints

Janosch Frank frankja at linux.ibm.com
Fri Nov 30 15:41:39 UTC 2018


The test already expects a ", " before the print of struct
padding. Let's add it to s390.c to make the output look a bit nicer and
fix test runs on z/VM that have padding at the end of the STHYI structs.

Signed-off-by: Janosch Frank <frankja at linux.ibm.com>
---
 s390.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/s390.c b/s390.c
index 422c08d..a00c274 100644
--- a/s390.c
+++ b/s390.c
@@ -472,10 +472,12 @@ decode_ebcdic(const char *ebcdic, char *ascii, size_t size)
 	do { \
 		if ((size_) > sizeof(*(hdr_)) && \
 		    !is_filled((char *) ((hdr_) + 1), '\0', \
-		               (size_) - sizeof(*(hdr_)))) \
+		               (size_) - sizeof(*(hdr_)))) {	\
+			tprints(", ");				   \
 			print_quoted_string((char *) ((hdr_) + 1), \
 					    (size_) - sizeof(*(hdr_)), \
 					    QUOTE_FORCE_HEX); \
+		} \
 	} while (0)
 
 static void
-- 
2.7.4



More information about the Strace-devel mailing list