[PATCH v1] changing mmap flags and memfd_create flags to print abbreviated values under -Xraw

[shankarapailoor]

Hi again!

As a follow up, under -Xraw do you think it is better to just show raw
values instead of the corresponding function call e.g
inet_addr("127.0.0.1"), htons, htonl, etc?

For example, instead of:

bind(3, {sa_family=0x2, sin_port=htons(0), sin_addr=inet_addr("0.0.0.0")}, 16)

we would have:

bind(3, {sa_family=0x2, sin_port=0, sin_addr=0x0}, 16)

Regards,
Shankara
On Mon, Nov 26, 2018 at 1:59 PM shankarapailoor
<shankarapailoor at gmail.com> wrote:
>
> Thanks Dmitry! I will add tests in the future like you showed.
>
> I have a few more traces where I observe flags even when running the
> trace with -Xraw. Here are a few:
>
> rt_tgsigqueueinfo(13471, 13471, SIG_0, {}) = 0
> rt_sigsuspend([QUIT], 8) = ? ERESTARTNOHAND (To be restarted if no handler)
> rt_sigaction(SIG_0, {sa_handler=0x20000080, sa_mask=[BUS FPE PWR],
> sa_flags=0}, 0x20000240, 16107701032088221702) = -1 EINVAL (Invalid
> argument)
>
> Would you say that the QUIT, SIG_0, sa_mask=[BUS FPE PWR] flags should
> be raw values under -Xraw? Furthermore, should sa_mask=[BUS FPE PWR]
> be an integer?
>
> Regards,
> Shankara
> On Mon, Nov 26, 2018 at 12:59 PM Dmitry V. Levin <ldv at altlinux.org> wrote:
> >
> > On Sun, Nov 25, 2018 at 05:14:51PM -0800, shankarapailoor wrote:
> > > Hi Dmitry,
> > >
> > > >Unfortunately, on the way to this
> > > mailing list something has converted all tabs to spaces, so I was not able
> > > to apply it.
> > >
> > > Sorry about that. My editor did that I think. I've run checkpatch.pl
> > > and it seems to not have an issue now.
> > >
> > > >I think we want to print the raw value in case of XLAT_STYLE_VERBOSE
> > > as well as XLAT_STYLE_RAW, but, unlike XLAT_STYLE_RAW, in case of
> > > XLAT_STYLE_VERBOSE we also want to print the symbolic representation.
> > >
> > > Thanks for letting me know. I've attached an updated patch based on
> > > the example you sent. Let me know what you think.
> >
> > Thanks, it's much better, but I had to tweak things here and there to make
> > it work properly in -Xverbose mode as well.  I've also added tests and
> > pushed to master.
> >
> >
> > --
> > ldv
> > --
> > Strace-devel mailing list
> > Strace-devel at lists.strace.io
> > https://lists.strace.io/mailman/listinfo/strace-devel
>
>
>
> --
> Regards,
> Shankara Pailoor



-- 
Regards,
Shankara Pailoor