[PATCH v1] changing mmap flags and memfd_create flags to print abbreviated values under -Xraw

Dmitry V. Levin ldv at altlinux.org
Mon Nov 26 20:59:28 UTC 2018


On Sun, Nov 25, 2018 at 05:14:51PM -0800, shankarapailoor wrote:
> Hi Dmitry,
> 
> >Unfortunately, on the way to this
> mailing list something has converted all tabs to spaces, so I was not able
> to apply it.
> 
> Sorry about that. My editor did that I think. I've run checkpatch.pl
> and it seems to not have an issue now.
> 
> >I think we want to print the raw value in case of XLAT_STYLE_VERBOSE
> as well as XLAT_STYLE_RAW, but, unlike XLAT_STYLE_RAW, in case of
> XLAT_STYLE_VERBOSE we also want to print the symbolic representation.
> 
> Thanks for letting me know. I've attached an updated patch based on
> the example you sent. Let me know what you think.

Thanks, it's much better, but I had to tweak things here and there to make
it work properly in -Xverbose mode as well.  I've also added tests and
pushed to master.


-- 
ldv
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.strace.io/pipermail/strace-devel/attachments/20181126/62aba514/attachment.bin>


More information about the Strace-devel mailing list