[PATCH 3/9] unwind: introduce an ifdef condition, CAN_UNWIND as the super-set of USE_LIBUNWIND

Dmitry V. Levin ldv at altlinux.org
Thu Mar 15 00:40:17 UTC 2018


On Wed, Mar 14, 2018 at 02:28:08AM +0900, Masatake YAMATO wrote:
> Using libdw as an alternative unwinder is planed. strace will can

strace will can?

Please pay a bit more attention to commit messages.
I understand they might look less important than the code,
but they have to be readable.

> print stack trace without libunwind. In such plan, USE_LIBUNWIND is not
> suitable to represent whether unwinder related code is compiled or
> not.
> 
> CAN_UNWIND is common definition in either case: linking with libunwind
> or linking with libdw.

Let's follow the current practice and use macros with HAVE_ and
USE_ prefix.  For example, HAVE_UNWINDER.


-- 
ldv
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.strace.io/pipermail/strace-devel/attachments/20180315/f3316446/attachment.bin>


More information about the Strace-devel mailing list