[PATCH v5 2/4] Move nl_netfilter_msg_types definition from netlink.c to netlink_netfilter.c

Chen Jingpiao chenjingpiao at gmail.com
Sun Mar 11 12:14:55 UTC 2018


The side effect of #include "xlat/nl_netfilter_msg_types.h" is
NFNL_MSG_BATCH_* constants properly defined in that header file.
While netlink.c does not use these constants itself,
netlink_netfilter.c is going to need them soon.

* defs.h (nl_netfilter_msg_types): New xlat prototype.
* netlink.c: Move inclusion of "xlat/nl_netfilter_msg_types.h" ...
* netlink_netfilter.c: ... here.
---
 defs.h              | 1 +
 netlink.c           | 1 -
 netlink_netfilter.c | 1 +
 3 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/defs.h b/defs.h
index de517b6f6..7ea8d7222 100644
--- a/defs.h
+++ b/defs.h
@@ -290,6 +290,7 @@ extern const struct xlat inet_protocols[];
 extern const struct xlat ip_type_of_services[];
 extern const struct xlat msg_flags[];
 extern const struct xlat netlink_protocols[];
+extern const struct xlat nl_netfilter_msg_types[];
 extern const struct xlat nl_route_types[];
 extern const struct xlat open_access_modes[];
 extern const struct xlat open_mode_flags[];
diff --git a/netlink.c b/netlink.c
index f5fa1f13a..038352e0d 100644
--- a/netlink.c
+++ b/netlink.c
@@ -53,7 +53,6 @@
 #include "xlat/nf_ulog_msg_types.h"
 #include "xlat/nl_audit_types.h"
 #include "xlat/nl_crypto_types.h"
-#include "xlat/nl_netfilter_msg_types.h"
 #include "xlat/nl_netfilter_subsys_ids.h"
 #include "xlat/nl_selinux_types.h"
 #include "xlat/nl_sock_diag_types.h"
diff --git a/netlink_netfilter.c b/netlink_netfilter.c
index a6028a1e5..eb361ed77 100644
--- a/netlink_netfilter.c
+++ b/netlink_netfilter.c
@@ -38,6 +38,7 @@
 # include <linux/netfilter/nfnetlink.h>
 
 # include "xlat/netfilter_versions.h"
+# include "xlat/nl_netfilter_msg_types.h"
 # include "xlat/nl_netfilter_subsys_ids.h"
 
 bool
-- 
2.16.2.348.g24cec2248.dirty



More information about the Strace-devel mailing list