[PATCH v2] tests: extend for decoding of udev_monitor_netlink_header

[Dmitry V. Levin]

On Sat, Mar 10, 2018 at 11:32:35PM +0530, Harsha Sharma wrote:
> * tests/netlink_kobject_uevent.c: Add test_nlmsg_type_udev.
> ---
> Changes in v2:
> * Add decoding of kernel messages
> * initialize udev_monitor_netlink_header with non-zero values
> * cover case for length exceeding size of structure
>  
>  tests/netlink_kobject_uevent.c | 65 ++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 65 insertions(+)
> 
> diff --git a/tests/netlink_kobject_uevent.c b/tests/netlink_kobject_uevent.c
> index cacab5fd..30f9f525 100644
> --- a/tests/netlink_kobject_uevent.c
> +++ b/tests/netlink_kobject_uevent.c
> @@ -27,9 +27,72 @@
>   */
>  
>  #include "tests.h"
> +#include <string.h>
>  #include <stdio.h>
>  #include <sys/socket.h>
> +#include <arpa/inet.h>
>  #include "netlink.h"
> +#include "netlink_kobject_uevent.h"
> +
> +static void
> +test_nlmsg_type_udev(const int fd)
> +{
> +	long ret;
> +	unsigned int offset = 8;
> +	struct udev_monitor_netlink_header uh = {
> +		.prefix = "libudev",
> +		.magic = htonl(0xfeedcafe),
> +		.header_size = sizeof(uh),
> +		.properties_off = 40,
> +		.properties_len = 299,
> +		.filter_subsystem_hash = htonl(0xc370b302),
> +		.filter_devtype_hash = htonl(0x10800000),
> +		.filter_tag_bloom_hi = htonl(0x2000400),
> +		.filter_tag_bloom_lo = htonl(0x10800000),
> +	};
> +	unsigned int len = sizeof(uh);
> +
> +	ret = sendto(fd, &uh, len + offset, MSG_DONTWAIT, NULL, 0);
> +	printf("sendto(%d, {{prefix=\"%s\", magic=htonl(%#x)"
> +	       ", header_size=%u, properties_off=%u, properties_len=%u"
> +	       ", filter_subsystem_hash=htonl(%#x)"
> +	       ", filter_devtype_hash=htonl(%#x)"
> +	       ", filter_tag_bloom_hi=htonl(%#x)"
> +	       ", filter_tag_bloom_lo=htonl(%#x)}, "
> +	       , fd, uh.prefix,
> +	       ntohl(uh.magic), uh.header_size, uh.properties_off,
> +	       uh.properties_len, ntohl(uh.filter_subsystem_hash),
> +	       ntohl(uh.filter_devtype_hash), ntohl(uh.filter_tag_bloom_hi),
> +	       ntohl(uh.filter_tag_bloom_lo));
> +	char buf[len + offset];
> +	memcpy(buf, &uh, len + offset);
> +	print_quoted_memory(buf + len, offset);
> +	printf("}, %u, MSG_DONTWAIT, NULL, 0) = %s\n",
> +	       len + offset, sprintrc(ret));
> +
> +}
> +
> +static void
> +test_nlmsg_type_kernel(const int fd)
> +{
> +	long ret;
> +	struct udev_monitor_netlink_header uh = {
> +		.prefix = "change@",
> +		.magic = htonl(0xfeedcafe),
> +		.header_size = sizeof(uh),
> +		.properties_off = 10,
> +		.properties_len = 299,
> +		.filter_subsystem_hash = htonl(0xfffffff),
> +		.filter_devtype_hash = htonl(0x10000000),
> +		.filter_tag_bloom_hi = htonl(0x2000400),
> +	};
> +
> +	ret = sendto(fd, &uh, sizeof(uh), MSG_DONTWAIT, NULL, 0);
> +	printf("sendto(%d, ", fd);
> +	print_quoted_memory(&uh, sizeof(uh) - 8);
> +	printf("..., %lu, MSG_DONTWAIT, NULL, 0) = %s\n",
> +	       sizeof(uh), sprintrc(ret));

This failed to compile on travis with the following diagnostics:

../../tests-m32/netlink_kobject_uevent.c: In function 'test_nlmsg_type_kernel':
../../tests-m32/netlink_kobject_uevent.c:94:9: error: format '%lu' expects argument of type 'long unsigned int', but argument 2 has type 'unsigned int' [-Werror=format=]
	       sizeof(uh), sprintrc(ret));
	       ^

-- 
ldv
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.strace.io/pipermail/strace-devel/attachments/20180311/40ec3641/attachment.bin>