[PATCH v3] tests: Add test for decoding of PTP_* ioctl commands

[Dmitry V. Levin]

On Thu, Mar 08, 2018 at 07:21:28PM +0530, Harsha Sharma wrote:
> * tests/ioctl_ptp.c: New file.
> * tests/.gitignore: Add ioctl_ptp.
> * tests/pure_executables.list: Likewise.
> * tests/gen_tests.in (ioctl_ptp): New entry.
[...]
> diff --git a/tests/ioctl_ptp.c b/tests/ioctl_ptp.c
> new file mode 100644
> index 00000000..4036d486
> --- /dev/null
> +++ b/tests/ioctl_ptp.c
> @@ -0,0 +1,160 @@
> +/*
> + * Check decoding of PTP_* commands of ioctl syscall.
> + *
> + * Copyright (c) 2017 Harsha Sharma <harshasharmaiitr at gmail.com>

It's 2018 already. :)

> + * All rights reserved.
> + *
> + * Redistribution and use in source and binary forms, with or without
> + * modification, are permitted provided that the following conditions
> + * are met:
> + * 1. Redistributions of source code must retain the above copyright
> + *    notice, this list of conditions and the following disclaimer.
> + * 2. Redistributions in binary form must reproduce the above copyright
> + *    notice, this list of conditions and the following disclaimer in the
> + *    documentation and/or other materials provided with the distribution.
> + * 3. The name of the author may not be used to endorse or promote products
> + *    derived from this software without specific prior written permission.
> + *
> + * THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRESS OR
> + * IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES
> + * OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED.
> + * IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT,
> + * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT
> + * NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
> + * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
> + * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
> + * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
> + * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
> + */
> +
> +#include "tests.h"
> +#include "xlat.h"
> +#include <fcntl.h>
> +#include <stdio.h>
> +#include <stdlib.h>
> +#include <sys/ioctl.h>
> +#include <inttypes.h>
> +#include <unistd.h>
> +
> +#ifdef HAVE_STRUCT_PTP_SYS_OFFSET

This will work, but the code would look slightly better
if you can placed this ifdef right after #include "tests.h".

[...]
> +static void
> +test_ptp0_device(void)
> +{
> +
> +	TAIL_ALLOC_OBJECT_CONST_PTR(struct ptp_clock_caps, caps);
> +	fill_memory(caps, sizeof(*caps));
> +	TAIL_ALLOC_OBJECT_CONST_PTR(struct ptp_sys_offset, sysoff);
> +	fill_memory(sysoff, sizeof(*sysoff));
> +
> +	static const char device[] = "/dev/ptp0";
> +	int fd = open(device, O_RDWR);
> +	if (fd < 0) {
> +		perror(device);
> +		return;
> +	}
> +
> +	/* PTP_CLOCK_GETCAPS */
> +	int getcaps_ret = ioctl(fd, PTP_CLOCK_GETCAPS, caps);
> +	if (getcaps_ret < 0) {
> +		printf("ioctl(%d, PTP_CLOCK_GETCAPS, %p) = %s\n",
> +		       fd, caps,  sprintrc(getcaps_ret));
> +	} else {
> +		printf("ioctl(%d, PTP_CLOCK_GETCAPS, {max_adj=%d, n_alarm=%d"
> +		    ", n_ext_ts=%d, n_per_out=%d, pps=%d}) = %s\n",
> +		    fd, caps->max_adj, caps->n_alarm, caps->n_ext_ts,
> +		    caps->n_per_out, caps->pps, sprintrc(getcaps_ret));
> +	}
> +
> +	/* PTP_SYS_OFFSET */
> +	int sysoff_ret = ioctl(fd, PTP_SYS_OFFSET, sysoff);
> +	if (sysoff_ret < 0) {
> +		printf("ioctl(%d, PTP_SYS_OFFSET, {n_samples=%u}) = %s\n",
> +		       fd, sysoff->n_samples, sprintrc(sysoff_ret));
> +	} else {
> +		unsigned int n_samples, i;
> +
> +		printf("ioctl(%d, PTP_SYS_OFFSET, ts=[", fd);
> +		n_samples = sysoff->n_samples > PTP_MAX_SAMPLES ?
> +			PTP_MAX_SAMPLES : sysoff->n_samples;
> +		for (i = 0; i < 2 * n_samples + 1; ++i) {
> +			if (i > 0)
> +				printf(", ");
> +			printf("{sec=%" PRId64 ", nsec=%" PRIu32 "}",
> +			       (int64_t)sysoff->ts[i].sec, sysoff->ts[i].nsec);
> +		}
> +		if (sysoff->n_samples > PTP_MAX_SAMPLES)
> +			printf(", ...");
> +		printf("]) = %s\n", sprintrc(sysoff_ret));
> +	}

With regards to sysoff->n_samples, as you control its value, it should be
set explicitly to a sane value, e.g. PTP_MAX_SAMPLES, otherwise the kernel
will return an error and the success path of PTP_SYS_OFFSET decoder will
not be tested.


-- 
ldv
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.strace.io/pipermail/strace-devel/attachments/20180310/0a061b10/attachment.bin>