Gabriel Laskar gabriel at
Mon Mar 5 09:57:37 UTC 2018

On Mon, 5 Mar 2018 14:31:16 +0530
Abhishek Tiwari <erabhishektiwarics at> wrote:

> Please do review patch.

It will be way simpler to review with the patch inlined, and not
attached to your mail.

As a starter:

* your commit message does not explain anything, a better message would
  be something like what you have in the NEWS file
* The NEWS file is not updated for the correct version. Also, most of
  the time, it is the maintainers that adds the digest of the version

* you did not answer to (message-id:
  <20180219142319.GJ4439 at>)
* Did you started to take into account remarks from  Masatake YAMATO
  and Eugene Syromiatnikov (discussion starts at message-id:
  <20180223.174751.218891701122588475.yamato at> ) about user
  defined groups instead of hardocoded ones ?

Gabriel Laskar

More information about the Strace-devel mailing list