[PATCH v2 1/5] mmap_cache: add customizable search function

[Masatake YAMATO]

On Tue, 3 Jul 2018 22:41:41 +0300, "Dmitry V. Levin" <ldv at altlinux.org> wrote:
> On Tue, Jun 12, 2018 at 02:10:59PM +0300, Dmitry V. Levin wrote:
>> On Thu, Jun 07, 2018 at 08:48:40PM +0900, Masatake YAMATO wrote:
>> > Dmitry,
>> > 
>> > Could you review the patch series starting from
>> > 
>> >       [PATCH v2 1/5] mmap_cache: add customizable search function
>> > 
>> > (if you missed) ?
>> > 
>> > Please, let me know if I should resend them here.
>> 
>> As you may have guessed I've been flooded reviewing patches from Eugene.
>> I'll do my best to review your patch series soon.  Sorry about this.
> 
> OK, I've reviewed this series and pushed the result to
> https://github.com/strace/strace/commits/yamato/kvm-vcpu

Thank you very much.

> I'm not quite happy with the interface, though.
> Could we think of something less cryptic than -K option?
> For example, -e kvm=verbose ?

I have more KVM related patches that extends the output like:

    # ./strace -KK -f -p 617 2>&1 | grep 'KVM_RUN\| K'
    ...
    [pid   664] ioctl(18, KVM_RUN, 0)       = 0 (KVM_EXIT_MMIO)
    K ready_for_interrupt_injection=1, if_flag=0, flags=0, cr8=0000000000000000, apic_base=0x000000fee00d00
    K phys_addr=0, len=1634035803, [33, 0, 0, 0, 0, 0, 0, 0], is_write=112
    [pid   664] ioctl(18, KVM_RUN, 0)       = 0 (KVM_EXIT_MMIO)
    K ready_for_interrupt_injection=1, if_flag=1, flags=0, cr8=0000000000000000, apic_base=0x000000fee00d00
    K phys_addr=0, len=1634035803, [33, 0, 0, 0, 0, 0, 0, 0], is_write=112
    ...

Look at the lines started from 'K'. More fields of vcpu status are
printed in the line.

So I would like to use "-e kvm=vcpu" instead of "-e kvm=verbose"
for THIS patch series that you reviewed.

In the future I would like to add "-e kvm=vcpu-verbose". With this
option strace prints the 'K' lines.

Are the options acceptable?
If yes, I will revise THIS patch series based on
the github branch.

Masatake YAMATO

> 
> -- 
> ldv