[PATCH v1] update quotactl to not print QCMD macro under Xraw

[shankarapailoor]

Hi Dmitry,

Attached is an updated patch.

Regards,
Shankara

On Fri, Dec 21, 2018 at 6:32 PM Dmitry V. Levin <ldv at altlinux.org> wrote:
>
> On Fri, Dec 21, 2018 at 06:22:13PM -0800, shankarapailoor wrote:
> > Hi,
> >
> > >First of all, I tried to build strace with this patch applied but
> > got a lot of similar errors of the following kind:
> >
> > What version of gcc do you use? I don't see these errors when running
> > make check. I use gcc 7.3.0
>
> Mine is gcc 8.2.
>
> Anyway, in your patch all these buffers (quotacmd_str, quotaid_str,
> invalid_cmd_str, and invalid_id_str) have the same size.
>
> > >Please keep this list sorted.
> >
> > I placed these according to unix sort utility which said -Xabbrev
> > should go before -xfs. Do you want capital letters after lowercase?
>
> No, just sort them using C locale, this way you'll get all quotactl-X*
> before all quotactl-x*.
>
>
> --
> ldv
> --
> Strace-devel mailing list
> Strace-devel at lists.strace.io
> https://lists.strace.io/mailman/listinfo/strace-devel



-- 
Regards,
Shankara Pailoor
-------------- next part --------------
A non-text attachment was scrubbed...
Name: v2-0001-quotactl-change-quotactl-to-properly-handle-Xraw.patch
Type: text/x-patch
Size: 12415 bytes
Desc: not available
URL: <http://lists.strace.io/pipermail/strace-devel/attachments/20181222/43cfd874/attachment.bin>