[PATCH v1] Changing print_dev_t to print raw device number if -Xraw

[Dmitry V. Levin]

On Sun, Dec 02, 2018 at 12:02:42PM -0800, shankarapailoor wrote:
> Hi Dmitry,
> 
> The attached patch just changes the major and minor ids that we print
> to hex. I am making this minor change a separate patch since I had to
> change a bunch of tests. I will send the other patch after hearing
> from you about this one.

Looks good, see my comments below.

[...]
> From 8206baa8fd6b8fd3bfb031de21a4e79c3d359015 Mon Sep 17 00:00:00 2001
> From: Shankara Pailoor <shankarapailoor at gmail.com>
> Date: Sun, 2 Dec 2018 11:57:10 -0800

> Subject: [PATCH v1] changing makedev to print major minor ids

The commit message is not quite descriptive.

> ---
>  print_dev_t.c                |  2 +-
>  tests/btrfs.c                | 14 +++++-----
>  tests/ioctl_dm.c             | 52 ++++++++++++++++++------------------
>  tests/ioctl_loop.c           |  8 +++---
>  tests/mknod.c                |  4 +--
>  tests/mknodat.c              |  6 ++---
>  tests/nlattr_unix_diag_msg.c |  2 +-
>  tests/ustat.c                |  8 +++---
>  tests/xstatx.c               |  4 +--
>  9 files changed, 50 insertions(+), 50 deletions(-)

I expected to see strace.1.in tests/bpf-obj_get_info_by_fd.c
in this list as well.

[...]
> diff --git a/tests/mknodat.c b/tests/mknodat.c
> index 318dc5a6..bde4b961 100644
> --- a/tests/mknodat.c
> +++ b/tests/mknodat.c
> @@ -47,10 +47,10 @@ main(void)
>  	printf("mknodat(-1, \"%s\", S_IFIFO|0600) = %ld %s (%m)\n",
>  	       sample, rc, errno2name());
>  
> -	dev = (unsigned long) 0xdeadbeef00000000ULL | makedev(1, 7);
> +	dev = (unsigned long) 0xdeadbeef00000000ULL | makedev(0x1, 0x7);

I don't think this hunk is needed.


-- 
ldv
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.strace.io/pipermail/strace-devel/attachments/20181205/325df0b3/attachment.bin>