[RFC/PATCH v1 1/3] fix decoder of ioctl EVIOCGBIT

[Zhibin Li]

OK, it's in linux/drivers/input/evdev.c:
line 812: in function handle_eviocgbit:
return bits_to_user(bits, len, size, p, compat_mode);
and then in function bits_to_user:
int len = BITS_TO_LONGS(maxbit) * sizeof(long);
...
return copy_to_user(p, bits, len) ? -EFAULT : len;
Correct me if I'm wrong, thanks :)

On Sat, Aug 18, 2018 at 2:13 PM Dmitry V. Levin <ldv at altlinux.org> wrote:

> On Tue, Aug 14, 2018 at 03:00:12AM +0800, Zhibin Li wrote:
> > On Tue, Aug 14, 2018 at 1:59 AM Dmitry V. Levin <ldv at altlinux.org>
> wrote:
> > > On Fri, Aug 10, 2018 at 07:12:42PM +0800, Zhibin Li wrote:
> [...]
> > > > (decode_bitset_): Fix the incorrect comparison between tcp->u_rval
> and
> > > > max_nr.
> > >
> > > Could you explain, please, why the comparison is incorrect?
> > >
> > It seems the return value of ioctl here is counted in bytes
>
> Could you point to the code that returns a value counted in bytes, please?
>
>
> --
> ldv
> --
> Strace-devel mailing list
> Strace-devel at lists.strace.io
> https://lists.strace.io/mailman/listinfo/strace-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.strace.io/pipermail/strace-devel/attachments/20180818/0a40a834/attachment.html>