[RFC/PATCH v1 1/3] fix decoder of ioctl EVIOCGBIT

Dmitry V. Levin ldv at altlinux.org
Mon Aug 13 17:59:48 UTC 2018

On Fri, Aug 10, 2018 at 07:12:42PM +0800, Zhibin Li wrote:
> EV_SYN in EVIOCGBIT should be decoded to get other event types EV_*, not
> the precise event codes SYN_*.

Sorry but I don't follow.  Could you elaborate, please?

> * evdev.c: Include "xlat/evdev_ev.h" and remove "xlat/evdev_sync.h".

This removes the last user of evdev_sync.  Should xlat/evdev_sync.in be
removed, too?

> (decode_bitset_): Fix the incorrect comparison between tcp->u_rval and
> max_nr.

Could you explain, please, why the comparison is incorrect?

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.strace.io/pipermail/strace-devel/attachments/20180813/09e95011/attachment.bin>

More information about the Strace-devel mailing list