[PATCH] tests: Include linux/stat.h

Dmitry V. Levin ldv at altlinux.org
Sun Aug 5 15:37:19 UTC 2018


On Sun, Aug 05, 2018 at 08:14:34AM -0700, Khem Raj wrote:
> On Sat, Aug 4, 2018 at 1:33 PM Dmitry V. Levin wrote:
> > On Sat, Aug 04, 2018 at 01:20:10PM -0700, Khem Raj wrote:
> > > Starting with glibc 2.28, sys/stat.h header will have the
> >
> > s/will have/has/ as glibc 2.28 has already been released.
> > In fact, starting with glibc commit glibc-2.28~105.
> 
> thats right, I will change the wording.
> 
> > > definition for struct statx, in which case including linux/stat.h should be
> > > avoided, in order to prevent a duplicate definition.
> >
> > Why linux/stat.h should be avoided in the test?
> 
> it complains otherwise of duplicate definitions
> 
> > Have you tried the latest HEAD from strace.git?
> 
> I have been using 4.23 release not latest master

While it's fine to report against the latest release,
it's advised to check the latest HEAD from strace.git.

> > In particular, what do you think about commit v4.23-37-g3dbffb7?
> 
> Can you point to exact commit on master?

Sure:
https://gitlab.com/strace/strace/commit/3dbffb7
https://github.com/strace/strace/commit/3dbffb7


-- 
ldv
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.strace.io/pipermail/strace-devel/attachments/20180805/272ddde7/attachment.bin>


More information about the Strace-devel mailing list