[PATCH v5] tests/fcntl.c: add test for print_f_owner_ex

[Dmitry V. Levin]

On Sun, Apr 08, 2018 at 12:10:14AM +0800, Zhibin Li wrote:
> *tests/fcntl.c (test_f_owner_ex_type_pid)
> (test_f_owner_ex_umove, test_f_owner_ex_printaddr)
> (test_f_owner_ex): New functions.
> (main): Use test_f_owner_ex.
> ---
>  tests/fcntl.c | 45 +++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 45 insertions(+)
> 
> diff --git a/tests/fcntl.c b/tests/fcntl.c
> index 4f62ca2a..e9db81ef 100644
> --- a/tests/fcntl.c
> +++ b/tests/fcntl.c
> @@ -69,12 +69,57 @@ test_flock64(void)
>  #endif
>  }
>  
> +static long
> +test_f_owner_ex_type_pid(const int cmd, const char *const cmd_name,
> +			 const int type, const char *const type_name,
> +			 const pid_t pid)
> +{
> +	struct f_owner_ex fo = { .type = type, .pid = pid };

What if you used TAIL_ALLOC_OBJECT_CONST_PTR to create an object
that cannot be read beyond its end?

> +
> +	long rc = invoke_test_syscall(cmd, &fo);
> +	printf("%s(0, %s, {type=%s, pid=%d}) = %s\n",
> +	       TEST_SYSCALL_STR, cmd_name, type_name, pid, sprintrc(rc));
> +	return rc;
> +}
> +
> +static void
> +test_f_owner_ex_umove(const int type, const char *const type_name, pid_t pid)
> +{
> +	long rc = test_f_owner_ex_type_pid(ARG_STR(F_SETOWN_EX),
> +					   type, type_name, pid);
> +	if (!rc)
> +		test_f_owner_ex_type_pid(ARG_STR(F_GETOWN_EX),
> +					 type, type_name, pid);
> +}
> +
> +static void
> +test_f_owner_ex_printaddr(const int cmd, const char *const cmd_name)
> +{
> +	long rc = invoke_test_syscall(cmd, (void *const)0x7ffde503d9e8);
> +	printf("%s(0, %s, 0x7ffde503d9e8) = %s\n",
> +	       TEST_SYSCALL_STR, cmd_name, sprintrc(rc));
> +}

Why this magic constant?  What guarantees that it doesn't reference
to a valid mapped memory?  How is it expected to work on 32-bit systems?


-- 
ldv
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.strace.io/pipermail/strace-devel/attachments/20180407/5cc6322a/attachment.bin>