[PATCH v4] Implemented -e trace=%clock option

[Dmitry V. Levin]

On Tue, Mar 28, 2017 at 05:17:49AM +0300, Dmitry V. Levin wrote:
> On Tue, Mar 28, 2017 at 03:42:04AM +0530, Rishi Bhatt wrote:
> > From 294db67743eb8509383cf80887747016271dd32a Mon Sep 17 00:00:00 2001
> > From: Rishi Bhatt <bhatt.rishi062 at gmail.com>
> > Date: Tue, 28 Mar 2017 03:31:24 +0530
> > Subject: [PATCH] Implement -e trace=%clock option
> > 
> > linux/*/syscallent.h part is modified automatically by:
> > 
> >     git grep -Fl 'SEN(clock_' linux/ | xargs sed -i \
> >         's/0\(,[[:space:]]*SEN(clock_\)/TCL\1/'
> > 
> > 	* sysent.h (TRACE_CLOCK): New definition.
> > 	* syscall.c: Alias TCL to TRACE_CLOCK around syscallent.h inclusion.
> > 	* linux/32/syscallent.h: Add TCL flag for clock_* sycalls.
> > 	* linux/64/syscallent.h: Likewise.
> > 	* linux/alpha/syscallent.h: Likewise.
> > 	* linux/arm/syscallent.h: Likewise.
> > 	* linux/avr32/syscallent.h: Likewise.
> > 	* linux/bfin/syscallent.h: Likewise.
> > 	* linux/crisv10/syscallent.h: Likewise.
> > 	* linux/hppa/syscallent.h: Likewise.
> > 	* linux/i386/syscallent.h: Likewise.
> > 	* linux/ia64/syscallent.h: Likewise.
> > 	* linux/m68k/syscallent.h: Likewise.
> > 	* linux/microblaze/syscallent.h: Likewise.
> > 	* linux/mips/syscallent-n32.h: Likewise.
> > 	* linux/mips/syscallent-n64.h: Likewise.
> > 	* linux/mips/syscallent-o32.h: Likewise.
> > 	* linux/powerpc/syscallent.h: Likewise.
> > 	* linux/powerpc64/syscallent.h: Likewise.
> > 	* linux/s390/syscallent.h: Likewise.
> > 	* linux/s390x/syscallent.h: Likewise.
> > 	* linux/sh/syscallent.h: Likewise.
> > 	* linux/sh64/syscallent.h: Likewise.
> > 	* linux/sparc/syscallent.h: Likewise.
> > 	* linux/sparc64/syscallent.h: Likewise.
> > 	* linux/x32/syscallent.h: Likewise.
> > 	* linux/x86_64/syscallent.h: Likewise.
> > 	* linux/xtensa/syscallent.h: Likewise.
> > 	* qualify.c (lookup_class): Add TRACE_CLOCK for "%clock".
> > 	* tests/ksysent.c: Define TCL to 0.
> > 	* tests/nsyscalls.c: Likewise.
> > 	* tests/clock.test: New test.
> > 	* tests/Makefile.am (DECODER_TESTS): Add it.
> > 	* strace.1 (.SS Filtering): Add information about %clock syscall class.
> 
> Please don't indent it this way.
> Besides that, the patch looks OK.

One more little thing I forgot to add: it's a user visible change so
it needs a NEWS entry similar to trace=%sched.


-- 
ldv
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.strace.io/pipermail/strace-devel/attachments/20170331/27ec32b9/attachment.bin>