[PATCH v7] Implement -e trace=%statfs option to trace and group statfs, statfs64, statvfs syscalls

[Dmitry V. Levin]

On Fri, Mar 31, 2017 at 03:14:52AM +0300, Dmitry V. Levin wrote:
> On Wed, Mar 29, 2017 at 03:31:42PM +0530, Abhishek Tiwari wrote:
> > From 67591d68122d57d19700f34b97accbd9cb9ba19f Mon Sep 17 00:00:00 2001
> > From: Abhishek Tiwari <erabhishektiwarics at gmail.com>
> > Date: Wed, 29 Mar 2017 14:33:34 +0530
> > Subject: [PATCH v7] Implement -e trace=%statfs option to trace and group
> >  statfs, statfs64, statvfs syscalls
> 
> I'm not sure what do you mean by "and group" here and in several other
> places.
> 
> "statfs, statfs64, and statvfs" would be more grammatically correct and
> easier to read than "statfs, statfs64, statvfs" (also in several places).
> 
> > linux/*/syscallent* part is modified automatically by:
> > 
> > 	git grep -Fl 'stat' linux/*/syscallent* | xargs sed -i \
> > 	  's/TF\(,[[:space:]]*SEN.*\((\|_\)statv\?fs\)\)/TF|TSF\1/'
> > 
> > * sysent.h (TRACE_STATFS): New definition.
> > * syscall.c: Alias TSF to TRACE_STATFS around syscallent.h inclusion.
> > * linux/32/syscallent.h: Add TSF flag to group statfs, statfs64,
> > statvfs sycalls.
> > * linux/64/syscallent.h: Likewise.
> > * linux/aarch64/syscallent.h: Likewise.
> > * linux/alpha/syscallent.h: Likewise.
> > * linux/arm/syscallent.h: Likewise.
> > * linux/avr32/syscallent.h: Likewise.
> > * linux/bfin/syscallent.h: Likewise.
> > * linux/crisv10/syscallent.h: Likewise.
> > * linux/hppa/syscallent.h: Likewise.
> > * linux/i386/syscallent.h: Likewise.
> > * linux/ia64/syscallent.h: Likewise.
> > * linux/m68k/syscallent.h: Likewise.
> > * linux/microblaze/syscallent.h: Likewise.
> > * linux/mips/syscallent-compat.h: Likewise.
> > * linux/mips/syscallent-n32.h: Likewise.
> > * linux/mips/syscallent-n64.h: Likewise.
> > * linux/mips/syscallent-o32.h: Likewise.
> > * linux/powerpc/syscallent.h: Likewise.
> > * linux/powerpc64/syscallent.h: Likewise.
> > * linux/s390/syscallent.h: Likewise.
> > * linux/s390x/syscallent.h: Likewise.
> > * linux/sh/syscallent.h: Likewise.
> > * linux/sh64/syscallent.h: Likewise.
> > * linux/sparc/syscallent.h: Likewise.
> > * linux/sparc64/syscallent.h: Likewise.
> > * linux/x32/syscallent.h: Likewise.
> > * linux/x86_64/syscallent.h: Likewise.
> > * linux/xtensa/syscallent.h: Likewise.
> 
> In some of these files, there is just statfs, in some others it's just
> statfs64, in a few more you change both statfs and statfs64, and statvfs
> is a very rare beast found only in one file.
> 
> Let's reorder the list of changed syscallent files into these groups so
> the changes being made would have more correct descriptions.
> 
> > * qualify.c (lookup_class): Add SCHED_STATFS for "%statfs"
> > * strace.1 (.SS Filtering): Add information about %statfs syscall class.
> > * tests/Makefile.am (DECODER_TESTS): Add trace_statfs.test.
> > * tests/ksysent.c: Define TSF to 0.
> > * tests/nsyscalls.c: Likewise.
> > * tests/trace_statfs.test: New test.
> 
> Besides that, the change looks good.

One more little thing: it's a user visible change so it needs a NEWS entry
similar to trace=%sched.


-- 
ldv
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.strace.io/pipermail/strace-devel/attachments/20170331/247477a3/attachment.bin>