[PATCH v4] Implemented -e trace=%clock option

Rishi Bhatt bhatt.rishi062 at gmail.com
Wed Mar 22 23:49:03 UTC 2017


I did not know much about version and all so next time i will take
everything into consideration.Sorry.

The patch is attached.

On Wed, Mar 22, 2017 at 6:39 AM, Eugene Syromyatnikov <evgsyr at gmail.com>
wrote:

> On Sun, Mar 19, 2017 at 07:37:22AM +0530, Rishi Bhatt wrote:
> > On Sun, Mar 19, 2017 at 6:34 AM, Dmitry V. Levin <ldv at altlinux.org>
> wrote:
> > > > From: Rishi Bhatt <bhatt.rishi062 at gmail.com>
> > > > Subject: [PATCH v4] Implemented -e trace=%clock option
> > >
> > > v4? Again?
> > >
> >
> > So which one is it?
> Judging by the amount of patches sent, it's more like v8. But I think
> Dmitry refers to the fact that you had already sent e-mail which had
> subject
> "[PATCH v4] Implemented..."
>
> Also, regarding the subject, in strace project traditionally commit message
> should be phrased as a sentence in active voice, present simple tense.
>
> > > > +#define TRACE_CLOCK          020000  /*Trace clock-related
> syscalls. */
> > >
> > > Unfortunately, I have to repeat myself:
> > >
> > > "Please follow the style used in the file you are patching,
> > > in particular, the style of comments."
> > >
> >
> > In clock.test,and any other file?
> In clock.test and any other file. I assume Dmitry refers to absence of
> space character before the start of comment body.
>
> ------------------------------------------------------------
> ------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> _______________________________________________
> Strace-devel mailing list
> Strace-devel at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/strace-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.strace.io/pipermail/strace-devel/attachments/20170323/85f87515/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Implement-e-trace-clock-option.patch
Type: text/x-patch
Size: 45112 bytes
Desc: not available
URL: <http://lists.strace.io/pipermail/strace-devel/attachments/20170323/85f87515/attachment.bin>


More information about the Strace-devel mailing list