[PATCH v6] Implement -e trace=%statfs option for tracing statfs like syscalls

Eugene Syromyatnikov evgsyr at gmail.com
Wed Mar 22 01:20:19 UTC 2017


On Sun, Mar 19, 2017 at 11:30:01AM +0530, Abhishek Tiwari wrote:
> Please review patch for bug in previous reply.
> 
> On Sun, Mar 19, 2017 at 6:11 AM, Dmitry V. Levin <ldv at altlinux.org> wrote:
> > On Sat, Mar 18, 2017 at 08:29:46PM +0530, Abhishek Tiwari wrote:
> > [...]
> >> +done << EOF
> >> +17 statfs
> >
> > Please add a test for statfs64 here as well.
> 
> 
> Sir,
> the statfs64.test file calls the statfs.test itself.
> On adding 17 statfs64 to my test file gives error
> 
> undefined: __NR_statfs64
This is quite possible on 64-bit architectures, as they have no need in
a separate syscall for retrieving some 64-bit values (like st_size and
st_blocks).

> Is adding following entries correct ?
Not really.

> In file tests/scno.h:
> 
> #ifndef __NR_statfs
> # define __NR_statfs64 (SYSCALL_BIT | 332 )
Note that this file is generated (as it is stated in its header), as it
is ABI-dependent.

> Is adding it to last entry fine ?
> 
> In file tests/ksysent.h:
> 
> #ifdef __NR_statfs
> [__NR_statfs64 & 0xffff] = "statfs64",
> 




More information about the Strace-devel mailing list