[PATCH v6] Implement -e trace=%statfs option for tracing statfs like syscalls

Abhishek Tiwari erabhishektiwarics at gmail.com
Sun Mar 19 05:10:02 UTC 2017


>>       git grep -Fl 'statfs' linux/*/syscallent* | xargs sed -i 's/0\(,[[:space:]]*SEN(osf_statfs\)/TSF\1/'
>>       git grep -Fl 'statfs' linux/*/syscallent* | xargs sed -i 's/0\(,[[:space:]]*SEN(.*_statfs\)/TSF\1/'
>>       git grep -Fl 'statvfs' linux/*/syscallent* | xargs sed -i 's/0\(,[[:space:]]*SEN(.*_statvfs\)/TSF\1/'
>
> Why do you need 3 commands where a single command would suffice?
>
> Why these entries don't have TF flag set in the first place?
> It's a bug that should be fixed with a separate commit.
>

I have added TF flag to osf_statfs, osf_statfs64, posix_statfs,
bsd43_statfs, sysv_statfs, sysv_statvfs, svr4_statfs, svr4_statvfs
which don't have TF flag set.

Below is patch attached for the same.

None of stat related syscalls have their corresponding flag set.
$  grep -nr '_\(\|f\|l\)stat' linux/*/syscallent*

Should these be updated with their corresponding tags ?
fstatfs*-> TD
lstat*-> TD
{,old_}stat*-> TF
or are they intensional?

sorry for redundancy. Will fix other too.


>
> --
> ldv
>
> ------------------------------------------------------------------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> _______________________________________________
> Strace-devel mailing list
> Strace-devel at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/strace-devel
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: v1-0001-Fixed-bug-by-adding-TF-flag-to-statfs-and-statvfs.patch
Type: text/x-patch
Size: 4640 bytes
Desc: not available
URL: <http://lists.strace.io/pipermail/strace-devel/attachments/20170319/b8e7bae5/attachment.bin>


More information about the Strace-devel mailing list