[PATCH v4] Implemented -e trace=%clock option

[Dmitry V. Levin]

On Sat, Mar 18, 2017 at 07:35:49PM +0530, Rishi Bhatt wrote:
> Hey if i am taking rt_sigretrun,nanosleep as negative testcases i am
> getting sigusr and sigalarm respectively, i should not get them right?
> Also sched.test is also failing for them. Well i have included fstat and
> open as negatives.
> 
> The way these test is made which expect the last output to be
> '+++ exited with 0 +++'  -> this is causing the test failure for some tests
> from the suite.Well should i work to make this test better or there is
> something else which i am not taking into consideration?

Some test programs cannot be easily reused for this %clock test because
they fork, raise/catch signals, etc.

But hundreds of test programs are well fit for this test: their strace
output consists of syscalls and the final "exited" line only.

> From ba969213641b0c80defc908a6921ba4b498de0a7 Mon Sep 17 00:00:00 2001
> From: Rishi Bhatt <bhatt.rishi062 at gmail.com>
> Date: Thu, 16 Mar 2017 14:41:55 +0530
> Subject: [PATCH v4] Implemented -e trace=%clock option

v4? Again?

[...]
> --- a/sysent.h
> +++ b/sysent.h
> @@ -22,5 +22,6 @@ typedef struct sysent {
>  #define TRACE_INDIRECT_SUBCALL	02000	/* Syscall is an indirect socket/ipc subcall. */
>  #define COMPAT_SYSCALL_TYPES	04000	/* A compat syscall that uses compat types. */
>  #define TRACE_SCHED		010000  /* Trace scheduler-related syscalls. */
> +#define TRACE_CLOCK		020000  /*Trace clock-related syscalls. */

Unfortunately, I have to repeat myself:

"Please follow the style used in the file you are patching,
in particular, the style of comments."


-- 
ldv
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.strace.io/pipermail/strace-devel/attachments/20170319/2af4c93a/attachment.bin>