[PATCH v6] Implement decoding of statx syscall

Victor Krapivensky krapivenskiy.va at phystech.edu
Sat Mar 18 14:36:27 UTC 2017


On Sat, Mar 18, 2017 at 10:44:09AM +0100, Eugene Syromyatnikov wrote:
> I haven't look at v7 of the patch yet, but coverage [1] shows that at least
> this line is not covered by the test.

The version of the patch you run coverage on is very old (it still has
reserved2 field of struct_statx of size 16). In newer ones, it is
covered.

> Only one branch in regards of of stx.field.nsec value is covered in all
> instances of this macro.

Yes. This seems to be a property of a filesystem. Anything I can do
about that?

> Only branch with abbrev(tcp) == 0 is covered.

> ... and this one, but this is a common problem of all current *stat*
> checks.

Should I add a test that checks that it abbreviates correctly?




More information about the Strace-devel mailing list