Gsoc Introduction.

Eugene Syromyatnikov evgsyr at gmail.com
Fri Mar 17 17:42:32 UTC 2017


On Fri, Mar 17, 2017 at 06:35:09PM +0100, Eugene Syromyatnikov wrote:
> Please format function declaration as following:
> 
> int
> nsfs_ioctl(struct tcb *tcp, unsigned int code, kernel_ulong_t arg) {
Oops. Opening curly brace should be on the next line, like this:

int
nsfs_ioctl(struct tcb *tcp, unsigned int code, kernel_ulong_t arg)
{

> 	if (!umove_or_printaddr(tcp, arg, &uid)) {
> 		printuid(", [", uid);
> 		tprints("]");
> 	}
Ahem. I forgot that the comma should be also printed in case of address
printing too, so it should be written like this:

	tprints(", ")
 	if (!umove_or_printaddr(tcp, arg, &uid)) {
 		printuid("[", uid);
 		tprints("]");
	}




More information about the Strace-devel mailing list