[PATCH v5] Implement decoding of statx syscall

Victor Krapivensky krapivenskiy.va at phystech.edu
Fri Mar 17 17:06:53 UTC 2017


On Thu, Mar 16, 2017 at 04:27:26AM +0300, Dmitry V. Levin wrote:
> This blank line at the end has caused this "git am" response:
> 
> Applying: Implement decoding of statx syscall
> .git/rebase-apply/patch:385: new blank line at EOF.
> +
> fatal: 1 line adds whitespace errors.
> Patch failed at 0001 Implement decoding of statx syscall
> 
> Please don't. :)

> If you move this unlink invocation, please add it on error paths.

> There is no diagnostics in case of IS_STATX.
> Someone seems to be too lazy to split the message. :)

> Please add that unlink(sample) call here.

Sorry for being this sloppy.




More information about the Strace-devel mailing list