GSOC: Introduction

Dmitry V. Levin ldv at altlinux.org
Sun Mar 5 21:50:11 UTC 2017


On Mon, Mar 06, 2017 at 03:00:05AM +0530, Abhishek Tiwari wrote:
> On Mon, Mar 6, 2017 at 12:43 AM, Dmitry V. Levin wrote:
> > On Sun, Mar 05, 2017 at 06:27:49PM +0530, Abhishek Tiwari wrote:
> >> On Sun, Mar 5, 2017 at 8:48 AM, Dmitry V. Levin wrote:
> >> > On Sun, Mar 05, 2017 at 01:54:33AM +0530, Abhishek Tiwari wrote:
> >> >> On Sat, Mar 4, 2017 at 5:41 PM, Abhishek Tiwari wrote:
[...]
> new file mode 100644
> index 0000000..fee14d1
> --- /dev/null
> +++ b/INSTALL-git.md
> @@ -0,0 +1,8 @@
> +Install Strace from git
> +=======================
> +If you use the GIT version of strace there will be some files missing
> +that you need to build strace.  These files are generated by tools from
> +the GNU Autoconf and Automake packages.
> +
> +Note: rather than running `autoreconf` directly, use the `./bootstrap` script
> +and follow the instructions given in given in [INSTALL](INSTALL) file for further installation.

strace is always lowercase, otherwise looks OK.

> diff --git a/README-hacking b/README-hacking
> index 16d12c0..ff8ce12 100644
> --- a/README-hacking
> +++ b/README-hacking
> @@ -1,10 +1,6 @@
>  Requirements
>  ============
> -If you use the GIT version of strace there will be some files missing
> -that you need to build strace.  These files are generated by tools from
> -the GNU Autoconf and Automake packages.
> -
> -Note: rather than run `autoreconf' directly, use the `./bootstrap' script.
> +If you use the GIT version of strace, please refer to INSTALL-git.md file.

This is OK.

> diff --git a/README.md b/README.md
> index 35663a1..14796b3 100644
> --- a/README.md
> +++ b/README.md
> @@ -4,6 +4,8 @@ strace is released under a Berkeley-style license at the request of Paul Kranenb
>  
>  See the file [NEWS](https://raw.githubusercontent.com/strace/strace/master/NEWS) for information on what has changed in recent versions.
>  
> +Please read the file [INSTALL-git](INSTALL-git) for installation instructions.
> +
>  Please send bug reports and enhancements to [the strace mailing list](https://lists.sourceforge.net/lists/listinfo/strace-devel).
>  
>  [![Build Status](https://travis-ci.org/strace/strace.svg?branch=master)](https://travis-ci.org/strace/strace) [![Code Coverage](https://codecov.io/github/strace/strace/coverage.svg?branch=master)](https://codecov.io/github/strace/strace?branch=master)

Looks OK, but README.md has changed today and this hunk no longer applies,
please rebase.

Also please update the commit message according to "Commit log
requirements" listed in README-hacking file.

> I was going through the mail archives to get understanding of code base.
> In the mail archive for extending -e trace=class, the following code
> section is referred,
[...]
> In qualify.c the given code section is not present, so how a new class
> is registered?

Yesterday a new trace class %sched was finally added with a test, please
have a look at the corresponding commit.


-- 
ldv
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.strace.io/pipermail/strace-devel/attachments/20170306/63fa92df/attachment.bin>


More information about the Strace-devel mailing list