[PATCH RFC v1 1/1] Initial support for Lua scripting

[Eugene Syromyatnikov]

On Fri, Jun 16, 2017 at 2:39 PM, Victor Krapivensky
<krapivenskiy.va at phystech.edu> wrote:
> On Thu, Jun 15, 2017 at 05:39:25PM +0000, Eugene Syromyatnikov wrote:
>> On Thu, Jun 15, 2017 at 3:28 PM, Eugene Syromiatnikov <esyr at redhat.com> wrote:
>> > Overall looks good.
>>
>> Well, except that mpers_defs.h also has STRINGIFY() macro and
>> undef'ing it in defs_reuse.h leads to breaking of mpers header
>> generation and breaking of the (clean) build, as a result. I'd suggest
>> renaming STRINGIFY() macro in defs_reuse.h.
>
> I think it would be better to rename STRINGIFY() macro in mpers_defs.h,
> so that it does not pollute the global namespace.
Well, I don't consider having a commonly used stringification macro a
namespace pollution. It also makes sense to move it to defs.h before
the mpers_type.h inclusion, for yet another option.

Also, sorry for misleading, the filename is actually mpers_type.h and
not mpers_defs.h.

> ------------------------------------------------------------------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> _______________________________________________
> Strace-devel mailing list
> Strace-devel at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/strace-devel



-- 
Eugene Syromyatnikov
mailto:evgsyr at gmail.com
xmpp:esyr at jabber.{ru|org}