[PATCH 1/6] tests: check decoding of NETLINK_SOCK_DIAG message types

Dmitry V. Levin ldv at altlinux.org
Mon Jun 5 00:47:32 UTC 2017

On Mon, Jun 05, 2017 at 08:11:20AM +0800, JingPiao wrote:
> * tests/netlink_sock_diag.test: New test.
On Mon, Jun 05, 2017 at 08:11:21AM +0800, JingPiao wrote:
> * tests/netlink_route.test: New test.
On Mon, Jun 05, 2017 at 08:11:22AM +0800, JingPiao wrote:
> * tests/netlink_audit.test: New test.
On Mon, Jun 05, 2017 at 08:11:23AM +0800, JingPiao wrote:
> * tests/netlink_netfilter.test: New test.
On Mon, Jun 05, 2017 at 08:11:24AM +0800, JingPiao wrote:
> * tests/netlink_selinux.test: New test.
On Mon, Jun 05, 2017 at 08:11:25AM +0800, JingPiao wrote:
> * tests/netlink_xfrm.test: New test.

$ sha1sum tests/netlink_*.test 
cc5e0bf3ca9ba46769731b815ff2562fece974af  tests/netlink_audit.test
cc5e0bf3ca9ba46769731b815ff2562fece974af  tests/netlink_netfilter.test
cc5e0bf3ca9ba46769731b815ff2562fece974af  tests/netlink_route.test
cc5e0bf3ca9ba46769731b815ff2562fece974af  tests/netlink_selinux.test
cc5e0bf3ca9ba46769731b815ff2562fece974af  tests/netlink_sock_diag.test
cc5e0bf3ca9ba46769731b815ff2562fece974af  tests/netlink_xfrm.test

As these tests have identical drivers, could this duplication be avoided,

tests/netlink_*.c also have a lot of common code.  For example, the only
difference between their main() functions is the netlink family constant
passed to socket() - it's very much the same create_socket() function from
your former "tests: add check for nlmsg_type decoding" commit.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.strace.io/pipermail/strace-devel/attachments/20170605/0ad7db2d/attachment.bin>

More information about the Strace-devel mailing list