[PATCH] strace.c: split trace() into next_event()/dispatch_event()

Victor Krapivensky krapivenskiy.va at phystech.edu
Thu Jun 1 21:38:01 UTC 2017


On Wed, May 31, 2017 at 06:58:07PM +0300, Dmitry V. Levin wrote:
> I'm very much in favour of this change, it makes the control flow easier
> to understand.  Technically, this patch looks correct, although I've spend
> a lot of my reviewing time to get to this conclusion.  Next time when you
> do refactoring, try making the change more obvious. :)

Okay. :)

> Do we need status variable along with *pstatus?

Probably yes, it saves a little extra dereferencing.




More information about the Strace-devel mailing list