[PATCH v4 2/6] Introduce new filtering architecture

[Nikolay Marchuk]

>> +#include "defs.h"
>> +#include <ctype.h>
>> +#include "filter.h"
>> +
>> +#define DECL_FILTER(name)						\
>> +extern void *								\
>> +parse_ ## name ## _filter(const char *);				\
>> +extern bool								\
>> +run_ ## name ## _filter(struct tcb *, void *);				\
>> +extern void								\
>> +free_ ## name ## _filter(void *)
> Missing indentation of the macro definition.
> 
>> +DECL_FILTER(syscall);
>> +DECL_FILTER(fd);
>> +#undef DECL_FILTER
>> +
>> +#define FILTER_TYPE(name)						\
>> +{#name, parse_ ## name ## _filter, run_ ## name ## _filter,		\
>> +	free_ ## name ## _filter}
> Missing indentation of the macro definition.
> 
>> +#include "defs.h"
>> +#include <ctype.h>
>> +#include "filter.h"
>> +
>> +#define DECL_FILTER_ACTION(name)					\
>> +extern void								\
>> +apply_ ## name(struct tcb *, void *)
> Missing indentation of the macro definition.
> 
>> +DECL_FILTER_ACTION(trace);
>> +DECL_FILTER_ACTION(inject);
>> +DECL_FILTER_ACTION(fault);
>> +DECL_FILTER_ACTION(read);
>> +DECL_FILTER_ACTION(write);
>> +DECL_FILTER_ACTION(raw);
>> +DECL_FILTER_ACTION(abbrev);
>> +DECL_FILTER_ACTION(verbose);
>> +#undef DECL_FILTER_ACTION
>> +
>> +extern bool is_traced(struct tcb *);
>> +extern bool not_injected(struct tcb *);
>> +
>> +#define DECL_FILTER_ACTION_PARSER(name)					\
>> +extern void *								\
>> +parse_ ## name(const char *);						\
>> +extern void								\
>> +free_ ## name(void *)
> Missing indentation of the macro definitions.
> 
>> +DECL_FILTER_ACTION_PARSER(null);
>> +DECL_FILTER_ACTION_PARSER(inject);
>> +DECL_FILTER_ACTION_PARSER(fault);
>> +#undef DECL_FILTER_ACTION_PARSER
>> +
>> +#define FILTER_ACTION_TYPE(NAME, PRIORITY, PARSER, PREFILTER)		\
>> +{#NAME, PRIORITY, parse_ ## PARSER, free_ ## PARSER, PREFILTER, apply_ ## NAME}
> Missing indentation of the macro definition.
What indentation should I use? I used DECL_* macros from defs.h as a
reference.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 213 bytes
Desc: OpenPGP digital signature
URL: <http://lists.strace.io/pipermail/strace-devel/attachments/20170725/91fce119/attachment.bin>