[PATCH 08/27] tests: checking decoding of crypto_user_alg CRYPTOCFGA_REPORT_LARVAL attributes

[Dmitry V. Levin]

On Sat, Jul 22, 2017 at 08:43:38PM +0800, JingPiao Chen wrote:
> * tests/nlattr_crypto_user_alg.c: New file.
> * tests/gen_tests.in (nlattr_crypto_user_alg): New entry.
> * tests/pure_executables.list: Add nlattr_crypto_user_alg.
> * tests/.gitignore: Likewise.
> ---
>  tests/.gitignore               |   1 +
>  tests/gen_tests.in             |   1 +
>  tests/nlattr_crypto_user_alg.c | 102 +++++++++++++++++++++++++++++++++++++++++
>  tests/pure_executables.list    |   1 +
>  4 files changed, 105 insertions(+)
>  create mode 100644 tests/nlattr_crypto_user_alg.c
> 
> diff --git a/tests/.gitignore b/tests/.gitignore
> index a75de08..47ecc6c 100644
> --- a/tests/.gitignore
> +++ b/tests/.gitignore
> @@ -212,6 +212,7 @@ netlink_unix_diag
>  netlink_xfrm
>  newfstatat
>  nlattr
> +nlattr_crypto_user_alg
>  nlattr_inet_diag_msg
>  nlattr_inet_diag_req_compat
>  nlattr_inet_diag_req_v2
> diff --git a/tests/gen_tests.in b/tests/gen_tests.in
> index 4cea36b..6bd324e 100644
> --- a/tests/gen_tests.in
> +++ b/tests/gen_tests.in
> @@ -195,6 +195,7 @@ netlink_selinux	+netlink_sock_diag.test
>  netlink_xfrm	+netlink_sock_diag.test
>  newfstatat	-a32 -v -P stat.sample -P /dev/full
>  nlattr		+netlink_sock_diag.test
> +nlattr_crypto_user_alg		+netlink_sock_diag.test
>  nlattr_inet_diag_msg		+netlink_sock_diag.test
>  nlattr_inet_diag_req_compat	+netlink_sock_diag.test
>  nlattr_inet_diag_req_v2		+netlink_sock_diag.test
> diff --git a/tests/nlattr_crypto_user_alg.c b/tests/nlattr_crypto_user_alg.c
> new file mode 100644
> index 0000000..79822eb
> --- /dev/null
> +++ b/tests/nlattr_crypto_user_alg.c
> @@ -0,0 +1,102 @@
> +/*
> + * Copyright (c) 2017 JingPiao Chen <chenjingpiao at gmail.com>
> + * Copyright (c) 2017 The strace developers.
> + * All rights reserved.
> + *
> + * Redistribution and use in source and binary forms, with or without
> + * modification, are permitted provided that the following conditions
> + * are met:
> + * 1. Redistributions of source code must retain the above copyright
> + *    notice, this list of conditions and the following disclaimer.
> + * 2. Redistributions in binary form must reproduce the above copyright
> + *    notice, this list of conditions and the following disclaimer in the
> + *    documentation and/or other materials provided with the distribution.
> + * 3. The name of the author may not be used to endorse or promote products
> + *    derived from this software without specific prior written permission.
> + *
> + * THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRESS OR
> + * IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES
> + * OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED.
> + * IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT,
> + * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT
> + * NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
> + * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
> + * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
> + * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
> + * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
> + */
> +
> +#include "tests.h"
> +
> +#ifdef HAVE_STRUCT_CRYPTO_REPORT_LARVAL
> +
> +# include <stdio.h>
> +# include <stdint.h>
> +# include "test_nlattr.h"
> +# include <linux/cryptouser.h>
> +
> +static void
> +init_crypto_user_alg(struct nlmsghdr *const nlh, const unsigned int msg_len)
> +{
> +	SET_STRUCT(struct nlmsghdr, nlh,
> +		.nlmsg_len = msg_len,
> +		.nlmsg_type = CRYPTO_MSG_GETALG,
> +		.nlmsg_flags = NLM_F_DUMP
> +	);
> +
> +	struct crypto_user_alg *const alg = NLMSG_DATA(nlh);
> +	SET_STRUCT(struct crypto_user_alg, alg,
> +		.cru_name = "abcd",
> +		.cru_driver_name = "efgh",
> +		.cru_module_name = "ijkl",
> +	);
> +}
> +
> +static void
> +print_crypto_user_alg(const unsigned int msg_len)
> +{
> +	printf("{len=%u, type=CRYPTO_MSG_GETALG"
> +	       ", flags=NLM_F_DUMP, seq=0, pid=0}"
> +	       ", {cru_name=\"abcd\", cru_driver_name=\"efgh\""
> +	       ", cru_module_name=\"ijkl\", cru_type=0"
> +	       ", cru_mask=0, cru_refcnt=0, cru_flags=0}",
> +	       msg_len);
> +}
> +
> +static void
> +print_quoted_nul_string(const char *str, const size_t len)
> +{
> +	print_quoted_memory(str, len);
> +	printf("...");
> +}

Why print_quoted_nul_string has been given this name?

> +
> +int
> +main(void)
> +{
> +	skip_if_unavailable("/proc/self/fd/");
> +
> +	const int fd = create_nl_socket(NETLINK_CRYPTO);
> +	const unsigned int hdrlen = sizeof(struct crypto_user_alg);
> +	void *const nlh0 = tail_alloc(NLMSG_SPACE(hdrlen));
> +
> +	static char pattern[4096];
> +	fill_memory_ex(pattern, sizeof(pattern), 'a', 'z' - 'a' + 1);
> +			

There are trailing spaces in main().


-- 
ldv
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.strace.io/pipermail/strace-devel/attachments/20170722/f25012f6/attachment.bin>