[PATCH] tests: enhance error diagostics

[Dmitry V. Levin]

On Sat, Dec 23, 2017 at 02:34:31AM +0530, Harsha Sharma wrote:
> * tests/init.sh: execute timeout command only when run with argument
> else print error "No command or test file specified"
> 
> Signed-off-by: Harsha Sharma <harshasharmaiitr at gmail.com>
> ---
>  tests/run.sh | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/run.sh b/tests/run.sh
> index d1b796ca..6ff69b4d 100755
> --- a/tests/run.sh
> +++ b/tests/run.sh
> @@ -9,4 +9,8 @@ TIMEOUT="timeout -k 5 -s XCPU $TIMEOUT_DURATION"
>  $TIMEOUT true > /dev/null 2>&1 ||
>  	TIMEOUT=
>  
> -exec $TIMEOUT "$@"
> +if [ $# -eq 0 ]; then
> +	echo "No command or test file specified"
> +else
> +	exec $TIMEOUT "$@"
> +fi

Why do you think this change is useful?

tests/run.sh is a part of test infrastructure,
is it natural to invoke this script without arguments?


-- 
ldv
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.strace.io/pipermail/strace-devel/attachments/20171223/3c6afb9b/attachment.bin>