[RFC 1/2] Rename xmalloc and xcalloc to strace_malloc and strace_calloc

Dmitry V. Levin ldv at altlinux.org
Tue Dec 5 10:52:10 UTC 2017


On Tue, Dec 05, 2017 at 07:01:02PM +0900, Masatake YAMATO wrote:
> I'm planning to linke strace with libiberty for mangling C++
> symbol appearted in stack trace enabled with -k option.
> 
> Both the names, xmalloc and xcalloc, are already used in the
> library. Therefore I rename the symbols defined in strace.

Aren't xmalloc and xcalloc provided by strace compatible with those
provided by libiberty?  If strace also provided xrealloc, would it be
sufficient for libiberty?  If for any reason we'd have to rename these
functions in strace, would it be enough just to add renaming macros,
e.g. to xmalloc.h?

> ---
>  bpf.c            | 2 +-
>  count.c          | 4 ++--
>  dyxlat.c         | 4 ++--
>  filter_qualify.c | 2 +-
>  mmsghdr.c        | 2 +-
>  number_set.c     | 2 +-
>  pathtrace.c      | 2 +-
>  perf.c           | 4 ++--
>  strace.c         | 4 ++--
>  syscall.c        | 4 ++--
>  unwind.c         | 8 ++++----
>  util.c           | 4 ++--
>  xmalloc.c        | 6 +++---
>  xmalloc.h        | 4 ++--
>  14 files changed, 26 insertions(+), 26 deletions(-)


-- 
ldv
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.strace.io/pipermail/strace-devel/attachments/20171205/45d71eed/attachment.bin>


More information about the Strace-devel mailing list