[PATCH 2/8] kvm: handle KVM_RUN and KVM_GET_VCPU_MMAP_SIZE, and KVM_GET_API_VERSION ioctl commands

Dmitry V. Levin ldv at altlinux.org
Fri Dec 1 06:49:28 UTC 2017


On Fri, Dec 01, 2017 at 02:45:52PM +0900, Masatake YAMATO wrote:
> * kvm.c (kvm_ioctl): Handle KVM_RUN, KVM_GET_VCPU_MMAP_SIZE
>   and KVM_GET_API_VERSION.
> 
> Signed-off-by: Masatake YAMATO <yamato at redhat.com>
> ---
>  kvm.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/kvm.c b/kvm.c
> index 8251ce7d..9fa7e248 100644
> --- a/kvm.c
> +++ b/kvm.c
> @@ -37,6 +37,10 @@ int
>  kvm_ioctl(struct tcb *const tcp, const unsigned int code, const kernel_ulong_t arg)
>  {
>  	switch (code) {
> +	/* Commands not taking any arguments. */

These commands don't use the argument, but the kernel checks whether the
argument is equal to zero or not, so the comment is not quite correct.

> +	case KVM_RUN:
> +	case KVM_GET_VCPU_MMAP_SIZE:
> +	case KVM_GET_API_VERSION:
>  	default:
>  		return RVAL_DECODED;

The change is correct, though.


-- 
ldv
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.strace.io/pipermail/strace-devel/attachments/20171201/439faed4/attachment.bin>


More information about the Strace-devel mailing list