[PATCH v8 02/12] Introduce new filtering architecture

[Dmitry V. Levin]

On Tue, Aug 22, 2017 at 08:33:01PM +0300, Dmitry V. Levin wrote:
> On Tue, Aug 22, 2017 at 01:01:43PM +0700, Nikolay Marchuk wrote:
[...]
> > diff --git a/filter_qualify.c b/filter_qualify.c
> > index 4283e769..ff54720a 100644
> > --- a/filter_qualify.c
> > +++ b/filter_qualify.c
> > @@ -38,16 +38,8 @@ struct number_set {
> >  	bool not;
> >  };
> > 
> > -struct number_set read_set;
> > -struct number_set write_set;
> >  struct number_set signal_set;
> > 
> > -static struct number_set abbrev_set[SUPPORTED_PERSONALITIES];
> > -static struct number_set inject_set[SUPPORTED_PERSONALITIES];
> > -static struct number_set raw_set[SUPPORTED_PERSONALITIES];
> > -static struct number_set trace_set[SUPPORTED_PERSONALITIES];
> > -static struct number_set verbose_set[SUPPORTED_PERSONALITIES];
> 
> Note that both basic_filters.c and filter_qualify.c define the same
> structure number_set.  This is absolutely unacceptable and I'm sorry
> I missed it while reviewing b75c5b14, otherwise it wouldn't appear
> in the first place.
> 
> I think I'll move all these number_set functions to a separate file
> and create a proper API header.

Done, please rebase.


-- 
ldv
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.strace.io/pipermail/strace-devel/attachments/20170823/7241d79f/attachment.bin>