[PATCH RESEND 1/8] netlink: call get_fd_nl_family before decode nlmsghdr

Dmitry V. Levin ldv at altlinux.org
Sat Aug 5 23:10:16 UTC 2017


On Tue, Aug 01, 2017 at 07:48:41AM +0800, JingPiao Chen wrote:
> Prepare for NETLINK_KOBJECT_UEVENT decode. The messages
> of NETLINK_KOBJECT_UEVENT do not contain nlmsghdr.
[...]
> (decode_nlmsghdr_with_payload): Skip family specific decoders
> for type < NLMSG_MIN_TYPE && type != NLMSG_DONE.
[...]
> @@ -182,7 +177,7 @@ decode_nlmsg_type(const uint16_t type, const unsigned int family)
>  	const struct xlat *xlat = netlink_types;
>  	const char *dflt = "NLMSG_???";
>  
> -	if (type != NLMSG_DONE && family < ARRAY_SIZE(nlmsg_types)) {
> +	if (type >= NLMSG_MIN_TYPE && family < ARRAY_SIZE(nlmsg_types)) {

Why?  How this is related to the rest of NETLINK_KOBJECT_UEVENT change?


-- 
ldv
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.strace.io/pipermail/strace-devel/attachments/20170806/bc37a313/attachment.bin>


More information about the Strace-devel mailing list