[PATCH 1/2] v4l2: Implement decoding of the remaining V4L2_BUF_TYPE_* types.

[Dmitry V. Levin]

On Fri, Apr 14, 2017 at 02:56:30AM +0300, Edgar Kaziahmedov wrote:
> On Fri, 14 Apr 2017 02:45:40 +0300, Dmitry V. Levin wrote:
> > On Fri, Apr 14, 2017 at 02:39:03AM +0300, Edgar Kaziahmedov wrote:
> > [...]
> > > --- a/configure.ac
> > > +++ b/configure.ac
> > > @@ -588,6 +588,10 @@ AC_CHECK_DECLS(m4_normalize([
> > >  [#include <sys/types.h>
> > >  #include <linux/sysctl.h>])
> > >  
> > > +AC_CHECK_MEMBERS(m4_normalize([
> > > +	struct v4l2_window.global_alpha,
> > > +	struct v4l2_sdr_format.buffersize
> > > +	]),,, [ #include <linux/videodev2.h> ])  
> > 
> > Please have a look at strace commit v4.11-639-ga8443f8.
> 
> Okay, I'll include remaining headers, but in this case I do not
> understand why it is necessary

If at least one field being tests was introduced before the header got
fixed, there is a difference.  If not, there is no difference, but it's
just easier to include all these headers and do not bother about the
difference.

Also, please move AC_CHECK_MEMBERS hunk after AC_CHECK_DECLS, this way
you'll see better whether they include their headers the same way or not.


-- 
ldv
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.strace.io/pipermail/strace-devel/attachments/20170414/bab5021e/attachment.bin>