[PATCH 1/2] v4l2: add all printings to print_v4l2_format

Dmitry V. Levin ldv at altlinux.org
Wed Apr 12 02:21:29 UTC 2017


On Mon, Apr 10, 2017 at 01:45:01PM +0300, Edgar Kaziahmedov wrote:
[...]
> +	/* VIDEO_OVERLAY is earlier than Linux-2.6.12-rc2 */
> +	case V4L2_BUF_TYPE_VIDEO_OVERLAY: {
> +		struct_v4l2_clip clip;
>  		tprints(prefix);
> -		tprints("fmt.win={???}");
> +		tprintf("fmt.win={left=%d, top=%d, width=%u, height=%u, field=",
> +			ARGS_RECT(f->fmt.win.w));
> +		printxval(v4l2_fields, f->fmt.win.field, "V4L2_FIELD_???");
> +		tprintf(", chromakey=%#x, clips=", f->fmt.win.chromakey);
> +		ret = print_array(tcp, ptr_to_kulong(f->fmt.win.clips),
> +				  f->fmt.win.clipcount, &clip, sizeof(clip),
> +				  umoven_or_printaddr, print_v4l2_clip, 0);
> +		tprintf(", clipcount=%u, bitmap=", f->fmt.win.clipcount);
> +		printaddr(ptr_to_kulong(f->fmt.win.bitmap));
> +		tprintf(", global_alpha=%#x}", f->fmt.win.global_alpha);

struct v4l2_window.global_alpha was introduced by commit
v2.6.22-rc1~1118^2~179, on earlier kernels it turns into a syntax error:

v4l2.c: In function 'print_v4l2_format_fmt':
v4l2.c:283: error: 'const struct v4l2_window' has no member named 'global_alpha'


-- 
ldv
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.strace.io/pipermail/strace-devel/attachments/20170412/fbfdce04/attachment.bin>


More information about the Strace-devel mailing list